Feature selection UI refactor #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #315828: Refactor "Feature Selection" to extract UI components in C4R. |
Pull Request Test Coverage Report for Build 5199588497
💛 - Coveralls |
vmilan
reviewed
Jun 5, 2023
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionUIDropdown.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionUIDropdown.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionUIDropdown.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionUIDropdown.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionUIGeometryChips.js
Show resolved
Hide resolved
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionUIToggleButton.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionWidgetUI.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionWidgetUI.js
Outdated
Show resolved
Hide resolved
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionUIToggleButton.js
Show resolved
Hide resolved
vmilan
approved these changes
Jun 6, 2023
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionUIDropdown.js
Outdated
Show resolved
Hide resolved
Comment on lines
+12
to
+16
| scrollbarWidth: 'none', | ||
| msOverflowStyle: 'none', | ||
| '&::-webkit-scrollbar': { | ||
| display: 'none' | ||
| } |
There was a problem hiding this comment.
ok, let's wait for the design QA 👍
packages/react-ui/src/widgets/FeatureSelectionWidgetUI/FeatureSelectionUIGeometryChips.js
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/315828/refactor-feature-selection-to-extract-ui-components-in-c4r [sc-315828]
Refactor FeatureSelectionWidgetUI split into many exported pieces + design revamp
Type of change
(choose one and remove the others)
Acceptance
This PR is needed to close project for drawing geometries in Workflows GeoJSON Editor.
This feature deals with theme / UI or internal elements used also in CARTO 3
More details to de defined...
Basic checklist