Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scatter Plot Widget: Add a skeleton for loading state #690

Merged
merged 8 commits into from
May 26, 2023

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented May 26, 2023

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #314283: New loader UI for widgets.

@coveralls
Copy link
Collaborator

coveralls commented May 26, 2023

Pull Request Test Coverage Report for Build 5092324143

  • 5 of 9 (55.56%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.07%) to 72.135%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/ScatterPlotWidgetUI/ScatterPlotSkeleton.js 3 7 42.86%
Totals Coverage Status
Change from base Build 5089160412: -0.07%
Covered Lines: 2108
Relevant Lines: 2696

💛 - Coveralls

@vmilan vmilan marked this pull request as ready for review May 26, 2023 15:10
@vmilan vmilan requested a review from VictorVelarde May 26, 2023 15:10
<DotsBox key={i} ml={i * 3}>
{[...Array(4)].map((_, i) => (
// Random margins are used to create the effect of a scatter plot
<Box mt={getRandomValue()} ml={getRandomValue()}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch! ✨

Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

VictorVelarde

This comment was marked as duplicate.

@VictorVelarde VictorVelarde merged commit 6aedc01 into master May 26, 2023
@VictorVelarde VictorVelarde deleted the feature/scatter-plot-skeleton branch May 26, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants