Improve Source types #687
Merged
Improve Source types #687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
VictorVelarde
commented
May 24, 2023
- id for Source is mandatory
- credentials: it can be omitted (and provided by setDefaultCredentials in deck.gl/carto)
- sqlParameters: it can be omitted
VictorVelarde
commented
May 24, 2023
| connection?: string; | ||
| credentials: Credentials; | ||
| queryParameters: QueryParameters; | ||
| connection: string; |
There was a problem hiding this comment.
mandatory, but it was missing!
VictorVelarde
commented
May 24, 2023
| @@ -7,10 +7,9 @@ import { AnyAction, Reducer } from 'redux'; | |||
| import { Feature, Polygon, MultiPolygon } from 'geojson'; | |||
|
|
|||
| type Source = SourceProps & { | |||
| id: string | |||
There was a problem hiding this comment.
now id is in SourceProps
There was a problem hiding this comment.
The rest in file are just formatter changes
Pull Request Test Coverage Report for Build 5081508370
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.