Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Range Widget: Add a skeleton for loading state #681

Merged
merged 24 commits into from
May 26, 2023
Merged

Range Widget: Add a skeleton for loading state #681

merged 24 commits into from
May 26, 2023
+93 −9

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented May 22, 2023

Description

Shortcut: https://app.shortcut.com/cartoteam/story/314283/new-loader-ui-for-widgets
[sc-314283]

Category and Comparative

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #314283: New loader UI for widgets.

@coveralls
Copy link
Collaborator

coveralls commented May 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5088543107

  • 5 of 7 (71.43%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 72.335%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/RangeWidgetUI/RangeSkeleton.js 3 4 75.0%
packages/react-ui/src/widgets/RangeWidgetUI/RangeWidgetUI.js 1 2 50.0%
Totals Coverage Status
Change from base Build 5088536307: -0.01%
Covered Lines: 2086
Relevant Lines: 2661
💛 - Coveralls

@vmilan vmilan marked this pull request as ready for review May 24, 2023 14:11
@vmilan vmilan requested review from VictorVelarde and a team May 24, 2023 14:11
VictorVelarde
VictorVelarde approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@vmilan vmilan merged commit fcea07a into master May 26, 2023
@vmilan vmilan deleted the feature/range-widget-skeleton branch May 26, 2023 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmilan @coveralls @VictorVelarde