Normalization functions for mask/viewports #680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #314403: Formula and Histogram widgets (viewport mode) is not displaying data with zoom = 0 --> BQ (check this one). |
Comment on lines
+3
to
+5
| import union from '@turf/union'; | ||
| import { getType } from '@turf/invariant'; | ||
| import { polygon, multiPolygon } from '@turf/helpers'; |
There was a problem hiding this comment.
Ok, it sounds like we should add those as peerDependencies in react-core, right?
There was a problem hiding this comment.
Don't we have them already?
Pull Request Test Coverage Report for Build 5077682259
💛 - Coveralls |
added 3 commits
May 22, 2023 19:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/314403/formula-and-histogram-widgets-viewport-mode-is-not-displaying-data-with-zoom-0-bq-check-this-one
This normalizes the spatial filter before sending it to the API for remote calculation