Bar & Histogram & Formula & ComparativeFormula Widgets: Add a skeleton for loading state #674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #314283: New loader UI for widgets. |
Pull Request Test Coverage Report for Build 5066552253
💛 - Coveralls |
|
|
||
| // Skeleton | ||
| MuiSkeleton: { | ||
| defaultProps: { |
There was a problem hiding this comment.
Ok, good to know we have some basics in common
| @@ -156,6 +156,7 @@ function BarWidget({ | |||
| height={height} | |||
| animation={animation} | |||
| filterable={filterable} | |||
| isLoading={isLoading} | |||
There was a problem hiding this comment.
Why is this injected externally? Shouldn't this be just a prop that the 'widget' launching the query, passes down to the UI?
There was a problem hiding this comment.
This is what I'm doing here, isn't it? passing down the prop from the parent to the UI, as in line 137 for the WrapperWidgetUI.
The logic was already there, but the UI wasn't receiving it.
There was a problem hiding this comment.
Yes, misunderstanding on my side. It's fine
|
@VictorVelarde added also the HistogramWidget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/314283/new-loader-ui-for-widgets
[sc-314283]