Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TablePagination fixes & DS application #673

Merged
merged 5 commits into from
May 18, 2023
Merged

TablePagination fixes & DS application #673

merged 5 commits into from
May 18, 2023

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented May 17, 2023

Description

Shortcut: https://app.shortcut.com/cartoteam/story/308963/fix-the-select-component-from-the-table-pagination
[sc-308963]
Fixes for TablePagination and also the main changes regarding design system.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #308963: Fix the [Select] component from the table pagination.

@coveralls
Copy link
Collaborator

coveralls commented May 17, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5011884820

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 71.956%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/theme/sections/components/dataDisplay.js 0 1 0.0%
Totals Coverage Status
Change from base Build 4993164794: -0.02%
Covered Lines: 2013
Relevant Lines: 2576
💛 - Coveralls

@vmilan vmilan requested review from VictorVelarde and a team May 17, 2023 17:40
@vmilan vmilan merged commit e1e8efd into master May 18, 2023
@vmilan vmilan deleted the feature/table-pagination-fix branch May 18, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbigg zbigg zbigg approved these changes

@VictorVelarde VictorVelarde Awaiting requested review from VictorVelarde

Assignees
No one assigned
Labels
design system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmilan @coveralls @zbigg