New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ReactDOMServer dependency and simplify avatar image fallback #672

Merged

vmilan merged 2 commits into master from feature/simplify-avatar-fallback

May 16, 2023

+4 −15

Contributor

vmilan commented May 16, 2023 •

edited

Loading

story: https://app.shortcut.com/cartoteam/story/314940/c4r-remove-reactdomserver-dependency-and-simplify-avatar-image-fallback
[sc-314940]

Cleanup discussed in the frontend weekly.


          Remove ReactDOMServer dependency and simplify avatar image fallback

bbf2681

shortcut-integration bot commented May 16, 2023

This pull request has been linked to Shortcut Story #314940: C4R - Remove ReactDOMServer dependency and simplify avatar image fallback.

Collaborator

coveralls commented May 16, 2023 •

edited

Loading

Pull Request Test Coverage Report for Build 4993025771

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.03%) to 71.972%

Totals
Change from base Build 4951476863:	-0.03%
Covered Lines:	2013
Relevant Lines:	2575

💛 - Coveralls


          changelog

88ae56b

vmilan requested a review from a team

May 16, 2023 14:20

zbigg approved these changes

View reviewed changes

Contributor

zbigg left a comment

LGTM

bbecquet approved these changes

View reviewed changes

vmilan merged commit a3c2952 into master

vmilan deleted the feature/simplify-avatar-fallback branch

May 16, 2023 14:27

Contributor

VictorVelarde commented May 16, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet