Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix histogram widget filter for max/min values #671

Conversation

moicalcob
Copy link
Contributor

@moicalcob moicalcob commented May 10, 2023

Description

Shortcut: https://app.shortcut.com/cartoteam/story/312083/histogram-widget-with-custom-max-value-displaying-values-outside-of-range#activity-313269

The Histogram widget max and min filters were not working correctly. We were filtering using an open interval, so these min/max values were not really being used.

With this change, we should be able to filter correctly using a custom min/max value.

Type of change

  • Fix

Acceptance

  1. Add a histogram widget with custom min/max values
  2. Check that the max/min values' filter is correctly applied
  • Max filter:
    May-10-2023 13-45-04

  • Min filter:
    May-10-2023 13-53-07

  1. Check that if there is one feature that has the same value as the max filter, the feature is not filtered
    May-10-2023 13-46-42

  2. Perform the same check with the min value
    May-10-2023 13-53-57

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@moicalcob moicalcob self-assigned this May 10, 2023
@shortcut-integration
Copy link

@moicalcob moicalcob changed the title Fixing histogram widget filter for max/min values Fix histogram widget filter for max/min values May 10, 2023
@moicalcob moicalcob requested a review from a team May 10, 2023 11:35
@moicalcob moicalcob added bug Something isn't working widgets labels May 10, 2023
@coveralls
Copy link
Collaborator

coveralls commented May 10, 2023

Pull Request Test Coverage Report for Build 4936543771

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.005%

Totals Coverage Status
Change from base Build 4929767265: 0.0%
Covered Lines: 2018
Relevant Lines: 2580

💛 - Coveralls

@moicalcob moicalcob marked this pull request as ready for review May 10, 2023 11:54
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@VictorVelarde VictorVelarde merged commit 1a2f7f5 into master May 11, 2023
@VictorVelarde VictorVelarde deleted the bug/sc-312083/histogram-widget-with-custom-max-value-displaying branch May 11, 2023 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working widgets
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants