Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paired buttons spacing when the button is from a different variant #668

Merged
merged 2 commits into from
May 8, 2023

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented May 8, 2023

story: https://app.shortcut.com/cartoteam/story/292993/workspace-settings-ui-improvements-bugfixing
[sc-292993]

Found a bug in the theme related to buttons: when you have 2 buttons inline, there is no horizontal padding if they are from different variants.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #292993: Workspace Settings: UI improvements & bugfixing.

@vmilan vmilan requested a review from a team May 8, 2023 12:24
@coveralls
Copy link
Collaborator

coveralls commented May 8, 2023

Pull Request Test Coverage Report for Build 4915053634

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.015%

Totals Coverage Status
Change from base Build 4896884929: 0.0%
Covered Lines: 2017
Relevant Lines: 2579

💛 - Coveralls

Copy link
Contributor

@zbigg zbigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vmilan vmilan merged commit 069e165 into master May 8, 2023
@vmilan vmilan deleted the feature/buttons-pairing-fix branch May 22, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants