react-ui: Add component typings #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4923407154
💛 - Coveralls |
vmilan
approved these changes
May 4, 2023
2ec6ffa to
1792ee1
Compare
1792ee1 to
7d4fdbe
Compare
VictorVelarde
approved these changes
May 8, 2023
There was a problem hiding this comment.
LGTM. If already finished, add a note to changelog and land into master @zbigg
vmilan
approved these changes
May 8, 2023
469d054 to
acda191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/306547
Provide proper typings for following components from
@carto/react-ui:ButtonLabelWithIndicatorPasswordFieldSelectFieldTypographyAccordionGroupAvatarUploadFieldAppBarAlso export all
*Propsdefinitions in same manner as MUI does.Type of change
(choose one and remove the others)
Acceptance
When importing
import { Typography } from '@carto/react-ui'the type of component should be properly detected by IDE and tsc compilerBasic checklist