-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widgets work on either mask or viewport #661
Widgets work on either mask or viewport #661
Conversation
This pull request has been linked to Shortcut Story #303989: Widgets wrongly operate on intersection between viewport and mask. |
Pull Request Test Coverage Report for Build 4873713026
💛 - Coveralls |
614e899
to
891c823
Compare
891c823
to
ebdd99c
Compare
325f67d
to
bb7cc40
Compare
…ntersection-between
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Thx also for the cleanup 👍🏻 . I'm only missing a short description added in the CHANGELOG, and I'll ping PS in slack for awareness
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Shortcut: https://app.shortcut.com/cartoteam/story/303989/widgets-wrongly-operate-on-intersection-between-viewport-and-mask
This PR removes the intersection between viewport and (optional) mask, when filtering features and calculating widgets.
New behavior:
Old behavior:
Also includes refactoring of
getGeometryToIntersect
:Polygon
orMultiPolygon
and notFeature
anymore