Calculation of widget using maps API #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #304698: Backend-based widget calculation using spatialFilter parameter. |
Pull Request Test Coverage Report for Build 5016122094
💛 - Coveralls |
added 12 commits
April 27, 2023 13:27
90a42a9 to
b6d0241
Compare
added 3 commits
May 3, 2023 17:12
c48b227 to
32f47cc
Compare
zbigg
approved these changes
May 4, 2023
| const isGet = url.length + JSON.stringify(queryParams).length <= URL_LENGTH; | ||
| if (isGet) { | ||
| url += '?' + new URLSearchParams(queryParams).toString(); | ||
| } else { | ||
| // undo the JSON.stringify, @todo find a better pattern |
There was a problem hiding this comment.
You can't get much better because you have to measure size of GET url few lines above and that must have proper url as input.
(btw, it should create proper URL first, measure and test and not rely of more less accourate assumptions that JSON.stringify(queryParams). is same length as new URLSearchParams(queryParams).toString() but that's other story)
This is done correctly in getStats albeit it's not much more readable.
There was a problem hiding this comment.
I'll try to introduce an utility function for this, in a later PR.
…culation-using-spatialfilter
…culation-using-spatialfilter
|
Im my opinion, we're ready to merge this PR. |
…culation-using-spatialfilter
…culation-using-spatialfilter
0c015e0 to
0c18699
Compare
VictorVelarde
approved these changes
May 18, 2023
Josmorsot
added a commit
that referenced
this pull request
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/304698
This introduces the possibility for widget to be calculated remotely, so using the maps API. It is the case today for global mode only. This PR adds supports for non-global widgets to offload calculation to the backed. This is also limited to non-tileset data source and data source using V3-API only.
When enabled, widgets are more reactive and don't need to wait for the complete dataset to be downloaded. In demo apps, widgets gets rendered before data is even shown on the map.
The point of control of the feature is the function
isRemoteCalculationSupported. Note that each widget must have this possibility turned on as well, via the initialisation parameterattemptRemoteCalculation, currently hardcoded totruefor widgets that supports the feature.No change in public API expected. Carto 4 React users won't be able to control this feature.