react-api: stats request uses POST for big queries/queryParameters #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #306016: Support for long queries in Builder. |
Pull Request Test Coverage Report for Build 4809279272
💛 - Coveralls |
| }); | ||
|
|
||
| test('query source - big queryParameters, should return stats using POST', async () => { | ||
| const huugeQueryParameters = Array.from(Array(5000)).reduce((r, _, i) => { |
| expect(res).toEqual(QUERY_TEST.output); | ||
|
|
||
| expect(fetchMock).toBeCalledWith(QUERY_TEST.url, { | ||
| method: 'POST', |
There was a problem hiding this comment.
@zbigg Should we check the method: 'GET' in the previous tests?
There was a problem hiding this comment.
GET is default in fetch api, and this assertion is exact match, so we should be safe
93a45a5 to
465c702
Compare
465c702 to
64feed9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/306016/support-for-long-queries-in-builder
@carto/react-apistatsrequest suport for long queries or queryParameters by using POST is get URL exceeds certain limits.Type of change
Acceptance
Please describe how to validate the feature or fix
If feature deals with theme / UI or internal elements used also in CARTO 3, please also add a note on how to do acceptance on that part.
Basic checklist