-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Histogram widget when there is just one row of data #653
Merged
VictorVelarde
merged 7 commits into
master
from
bug/sc-292405/ac-7xhfwyml-carto-3-histogram-widget-does
Apr 25, 2023
Merged
Fix Histogram widget when there is just one row of data #653
VictorVelarde
merged 7 commits into
master
from
bug/sc-292405/ac-7xhfwyml-carto-3-histogram-widget-does
Apr 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request has been linked to Shortcut Story #292405: [ac_7xhfwyml] CARTO 3 Histogram Widget Does Not Render when Same Number in all of Column. |
Pull Request Test Coverage Report for Build 4799931815
💛 - Coveralls |
eamador
reviewed
Apr 19, 2023
eamador
approved these changes
Apr 19, 2023
VictorVelarde
approved these changes
Apr 25, 2023
@@ -200,9 +207,9 @@ function HistogramWidgetUI({ | |||
return { | |||
type: 'rect', | |||
shape: { | |||
x: x + (isFirst ? 0 : 1), | |||
x: isUniqueDataRow ? x / 10 : x + (isFirst ? 0 : 1), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, why 10 value here?
Thx @moicalcob, we'll ship it in next 2.0.2, this week |
VictorVelarde
deleted the
bug/sc-292405/ac-7xhfwyml-carto-3-histogram-widget-does
branch
April 25, 2023 16:32
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: (https://app.shortcut.com/cartoteam/story/292405/ac-7xhfwyml-carto-3-histogram-widget-does-not-render-when-same-number-in-all-of-column)
When we're showing just one row of data into a Histogram widget, we were not showing any bar into the widget due to how the Apache E-charts config was generated. With this PR we'll start checking if we just have one row of data to generate the proper options for the widget.
Type of change
Acceptance
Acceptance in CARTO 3
_num
columnBasic checklist