Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve upgrade guide documentation #651

Merged
merged 5 commits into from
Apr 14, 2023
Merged

Improve upgrade guide documentation #651

merged 5 commits into from
Apr 14, 2023

Conversation

vmilan
Copy link
Contributor

@vmilan vmilan commented Apr 14, 2023

Description

Shortcut: (306615)
[sc-306615]

As expressed in https://docs.google.com/document/d/1Xi-xu_BE93Pww6a2f0Ci8RjFhQxHTh5PUIvTilMADXE/edit# we want to expand the new custom Components.

Complete the list of custom components and improve their documentation to be ease to use them.

Reorg the file to be more clear.

File here: https://github.com/CartoDB/carto-react/blob/feature/upgrade-doc/UPGRADE.md

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #306615: TOOLING C4R - Improve upgrade guide in C4R.

@coveralls
Copy link
Collaborator

coveralls commented Apr 14, 2023

Pull Request Test Coverage Report for Build 4698895608

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.345%

Totals Coverage Status
Change from base Build 4698236894: 0.0%
Covered Lines: 1949
Relevant Lines: 2513

💛 - Coveralls

@vmilan vmilan requested a review from a team April 14, 2023 10:32
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, 👍🏻

@vmilan vmilan merged commit a8e5081 into master Apr 14, 2023
@vmilan vmilan deleted the feature/upgrade-doc branch April 14, 2023 10:46
@zbigg zbigg mentioned this pull request Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants