Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate 'BarWidgetUI' from makeStyles to styled-component + cleanup #644

Merged
merged 3 commits into from
May 5, 2023

Conversation

jantolg
Copy link
Contributor

@jantolg jantolg commented Apr 12, 2023

Description

This PR includes a refactorization of BarWidgetUI component, all classes from makestyles are been converted to styled components

Shortcut: 297037

Type of change

  • Refactor

Acceptance

The code resultant must return same styles component visualization as the same before changes

  1. Overview a general visualization from v1.x to v2.x

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@jantolg jantolg requested review from VictorVelarde and vmilan April 12, 2023 14:30
@coveralls
Copy link
Collaborator

coveralls commented Apr 12, 2023

Pull Request Test Coverage Report for Build 4896399554

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.755%

Totals Coverage Status
Change from base Build 4894626453: 0.0%
Covered Lines: 1991
Relevant Lines: 2553

💛 - Coveralls

Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx a lot

@VictorVelarde VictorVelarde merged commit 544c21a into master May 5, 2023
@VictorVelarde VictorVelarde deleted the feat/migrate-styles-component-bar-widget-ui branch May 5, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants