Migrate 'LegendWidgetUI' component from makeStyles to styled-component + cleanup #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mponent + cleanup
vmilan
reviewed
Apr 12, 2023
| minWidth: '240px', | ||
| backgroundColor: theme.palette.background.paper, | ||
| boxShadow: theme.shadows[1], | ||
| borderRadius: 4 |
| flexDirection: 'row', | ||
| alignItems: 'center', | ||
| justifyContent: 'space-between', | ||
| height: '36px' |
Pull Request Test Coverage Report for Build 4698253318
💛 - Coveralls |
|
I've fixed the visual difference
|
CHANGELOG.md
Outdated
| @@ -6,6 +6,8 @@ | |||
| - Note component cleaned styles from makeStyles [#630](https://github.com/CartoDB/carto-react/pull/630) | |||
| - OpacityControl component migrated from makeStyles to styled-components + cleanup [#631](https://github.com/CartoDB/carto-react/pull/631) | |||
|
|
|||
| borderRadius: 4 | ||
| } | ||
| const LegendBox = styled(Box)(({ theme }) => ({ | ||
| minWidth: '240px', |
|
@jantolg @aaranadev the text is still cut, can you take a look please? |
vmilan
approved these changes
Apr 14, 2023
| @@ -1,6 +1,5 @@ | |||
| import React, { useState } from 'react'; | |||
| import LegendWidgetUI from '../../../src/widgets/legend/LegendWidgetUI'; | |||
| import CartoIcon from '../../assets/carto-symbol.svg'; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a refactorization of LegendWidgetUI component, all classes from makestyles are been converted to styled components
Shortcut: 297037
Type of change
Acceptance
The code resultant must returns same styles component visualization as the same before changes
Basic checklist