Migrate 'LegendProportion' component from makeStyles to styled-components + cleanup #635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmilan
reviewed
Apr 12, 2023
Comment on lines
37
to
40
| <Circle index={0} component='span'></Circle> | ||
| <Circle index={1} component='span'></Circle> | ||
| <Circle index={2} component='span'></Circle> | ||
| <Circle index={3} component='span'></Circle> |
There was a problem hiding this comment.
Maybe would be simpler just to do something like this:
{[...Array(4)].map((circle, index) => (
<Circle index={index} component='span'></Circle>
))}
| @@ -48,7 +48,7 @@ function LegendProportion({ legend }) { | |||
| spacing={1} | |||
| > | |||
| {error ? ( | |||
| <Grid item className={classes.errorContainer}> | |||
| <Grid item xs maxWidth={240}> | |||
There was a problem hiding this comment.
Do you need xshere? or is it a leftover?
Comment on lines
9
to
16
| const sizes = { | ||
| 0: 96, | ||
| 1: 72, | ||
| 2: 48, | ||
| 3: 24 | ||
| }; | ||
| const width = `${sizes[index]}px`; | ||
| const height = `${sizes[index]}px`; |
There was a problem hiding this comment.
You could use theme.spacing() also here.
Take a look at this component to see an example: packages/react-ui/src/components/molecules/Avatar.js
|
I've fixed the visual difference
|
Pull Request Test Coverage Report for Build 4690753089
💛 - Coveralls |
vmilan
approved these changes
Apr 13, 2023
There was a problem hiding this comment.
UI LGTM, just adds a note in the changelog please, and wait for @VictorVelarde review before merging.
Thanks!!
VictorVelarde
approved these changes
Apr 13, 2023
10411ba to
9ca557a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes a refactorization of LegendProportion component, all classes from makestyles are been converted to styled components
Shortcut: 297037
Type of change
Acceptance
The code resultant must return same styles component visualization as the same before changes
Basic checklist