New DS core component: accordion #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4689752857
💛 - Coveralls |
zbigg
reviewed
Apr 13, 2023
|
|
||
| ...(variant === 'outlined' && { | ||
| backgroundColor: theme.palette.background.paper, | ||
| boxShadow: `inset 0 0 0 1px ${theme.palette.divider}` |
There was a problem hiding this comment.
Out of curiosity.
We've got theme.shadows. Are they of no use here? If not, when they should be used (they are used in extensively in cloud-native)
There was a problem hiding this comment.
This boxShadow use is custom, to simulate a border indeed... Designers wanted to have this line inside the element itself, and using an inset border didn't work properly.
But yes, we use theme.shadows for common use cases.
| const Template = ({ ...args }) => { | ||
| return <Avatar {...args} />; | ||
| }; | ||
|
|
||
| const ShapeTemplate = ({ ...args }) => { | ||
| const classes = useStyles(); |
There was a problem hiding this comment.
Nice to use the opportunity for cleanup!
zbigg
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: (302856)
Implement this core component needed by Workflows product.