Add sortByColumnType param to fix number sorting in TableWidget #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 4106367214
💛 - Coveralls |
| @@ -21,20 +25,21 @@ export function applySorting(features, { sortBy, sortByDirection = 'asc' } = {}) | |||
| if (!isValidSortBy) { | |||
| throw new Error('Sorting options are bad formatted'); | |||
| } | |||
|
|
|||
| const isNumberColumn = sortByColumnType === 'integer' || sortByColumnType === 'float'; | |||
There was a problem hiding this comment.
I guess this should be better a simple 'number'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TableWidget - sortByColumnType param + number format
Shortcut: https://app.shortcut.com/cartoteam/story/286648/ac-x5e68ikj-table-widget-ordering-is-wrong-for-numeric-data-type-column
TableWidget accepts a new
sortByColumnTypeparameter, if its value isinteger or float'number' we will apply number sortingTableWidgetSorting.mov
Type of change
Acceptance
Sorting by a number column should work properly