New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Provide unified clientId for metrics #591

Merged

VictorVelarde merged 2 commits into master from fix-client-id

Feb 2, 2023

Contributor

VictorVelarde commented Feb 1, 2023 •

edited

Loading

Description

Shortcut: https://app.shortcut.com/cartoteam/story/288237

Unified to 'carto-for-react', vs previous inconsistent 'carto-react' / 'carto-for-react' when calling SQL & MAP apis

Type of change

Fix

Acceptance

Basic checklist

Good PR name
Shortcut link
Changelog entry
Just one issue per PR
GitHub labels
Proper status & reviewers
Tests
Documentation

VictorVelarde requested a review from eamador

February 1, 2023 13:33


          Provide unified CLIENT_ID for metrics

9a401b2

VictorVelarde force-pushed the fix-client-id branch from d155d35 to 9a401b2 Compare

February 1, 2023 13:33

padawannn approved these changes

View reviewed changes


          Fix test

d205d35

Collaborator

coveralls commented Feb 1, 2023

Pull Request Test Coverage Report for Build 4066598147

1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 71.511%

Totals
Change from base Build 4057447293:	0.0%
Covered Lines:	1890
Relevant Lines:	2447

💛 - Coveralls

VictorVelarde merged commit 780a6d8 into master

VictorVelarde deleted the fix-client-id branch

February 2, 2023 15:11

Contributor Author

VictorVelarde commented Apr 19, 2023

This 'carto-for-react' was the agreement with Product

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet