Improved Comparative Formula UI #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3966439936
💛 - Coveralls |
…eact into fix/ComparativeFormulaUI
Comment on lines
+62
to
+66
| .map((d, i) => ({ | ||
| ...d, | ||
| color: getColor(colors, i) | ||
| })) | ||
| .filter((d) => d.value !== undefined), |
There was a problem hiding this comment.
You're doing here first .map and then .filter, vs previous .filter > .map. Is it intended @aaranadev?
There was a problem hiding this comment.
Yes, we need to remove the undefined values, but we need to assign the correct color index before the element is removed it.
Example:
If the second value is undefined, we need the value after the first to have the third color and not the second.
VictorVelarde
approved these changes
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains an improved ComparativeFormulaUI props interface with simplification and improvement of docs and tests.
Type of change
Basic checklist