Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FeaturesDroppedLoader to extract header value #561

Merged
merged 3 commits into from
Jan 12, 2023

Conversation

felixpalmer
Copy link
Contributor

Description

Shortcut

Type of change

  • Refactor

Acceptance

I have struggled to link the C4R codebase to another project, and had to test by copying files across into a modified project. For full acceptance it would be good for someone with more experience working with C4R to try linking in this modified code into an existing app to verify the feature dropping behavior works as expected

@felixpalmer
Copy link
Contributor Author

Related fix in Builder: https://github.com/CartoDB/cloud-native/pull/10499

@coveralls
Copy link
Collaborator

coveralls commented Jan 10, 2023

Pull Request Test Coverage Report for Build 3900835381

  • 0 of 4 (0.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 71.802%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-api/src/hooks/useTileFeatures.js 0 1 0.0%
packages/react-api/src/hooks/FeaturesDroppedLoader.js 0 3 0.0%
Files with Coverage Reduction New Missed Lines %
packages/react-api/src/hooks/useTileFeatures.js 1 27.94%
Totals Coverage Status
Change from base Build 3838259542: 0.2%
Covered Lines: 1878
Relevant Lines: 2428

💛 - Coveralls

Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@felixpalmer felixpalmer merged commit de7ded9 into master Jan 12, 2023
@felixpalmer felixpalmer deleted the felix/loader-cleanup branch January 12, 2023 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants