Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve rendering performance of FeatureSelectionLayer (mask layer) #541

Merged
merged 3 commits into from
Nov 29, 2022
Merged

Improve rendering performance of FeatureSelectionLayer (mask layer) #541

merged 3 commits into from
Nov 29, 2022

Conversation

felixpalmer
Copy link
Contributor

Description

Performance fixes related to https://github.com/CartoDB/carto-kepler/pull/132

  • Don't needlessly render FeatureSelectionLayer when there is no mask
  • Add a dataComparator to avoid layer state updates when mask polygon isn't changing

Type of change

  • Fix

Acceptance

Smoke tests related to the mask tool. Create/destroy a few masks with/without layers.

@felixpalmer felixpalmer requested a review from bbecquet November 29, 2022 08:50
@coveralls
Copy link
Collaborator

coveralls commented Nov 29, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3572573819

  • 0 of 9 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 71.599%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-widgets/src/layers/FeatureSelectionLayer.js 0 9 0.0%
Totals Coverage Status
Change from base Build 3549706895: -0.02%
Covered Lines: 1879
Relevant Lines: 2435
💛 - Coveralls

bbecquet
bbecquet approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@bbecquet bbecquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and efficient, LGTM

@VictorVelarde VictorVelarde changed the title Rendering performance improvements Improve rendering performance of FeatureSelectionLayer (mask layer) Nov 29, 2022
VictorVelarde
VictorVelarde approved these changes Nov 29, 2022
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@VictorVelarde VictorVelarde merged commit 6ca27b4 into master Nov 29, 2022
@VictorVelarde VictorVelarde deleted the felix/perf-improvements branch November 29, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

@bbecquet bbecquet bbecquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@felixpalmer @coveralls @bbecquet @VictorVelarde