Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix executeSQL through POST requests #531

Merged
merged 3 commits into from
Nov 18, 2022
Merged

Fix executeSQL through POST requests #531

merged 3 commits into from
Nov 18, 2022

Conversation

Josmorsot
Copy link
Contributor

@Josmorsot Josmorsot commented Nov 14, 2022 •
edited
Loading

Description

Issue: #499

executeSQL function doesn't work properly through POST

Type of change

  • Fix

@Josmorsot Josmorsot added the bug Something isn't working label Nov 14, 2022
@coveralls
Copy link
Collaborator

coveralls commented Nov 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3460252476

  • 8 of 8 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 72.442%
Totals Coverage Status
Change from base Build 3431257888: 0.02%
Covered Lines: 1847
Relevant Lines: 2374
💛 - Coveralls

@Josmorsot Josmorsot changed the title Fix executeSQL with POST requests Fix executeSQL through POST requests Nov 14, 2022
eamador
eamador approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@eamador eamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@Josmorsot Josmorsot merged commit 00bfd8e into master Nov 18, 2022
@Josmorsot Josmorsot deleted the fix-execute-sql branch November 18, 2022 06:44
Josmorsot added a commit that referenced this pull request Nov 18, 2022
@Josmorsot
Fix executeSQL through POST requests (#531)
631c883
vmilan added a commit that referenced this pull request Jan 12, 2023
@vmilan
Cherry pick from #531 PR (#564)
071e54c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamador eamador eamador approved these changes

@VictorVelarde VictorVelarde Awaiting requested review from VictorVelarde

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Josmorsot @coveralls @eamador