Fix TileLayer unauthorized error due to breaking changes in deck.gl #519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3378935863
💛 - Coveralls |
Authorization header to fetch requests
| @@ -157,12 +157,12 @@ export default function useTileFeatures({ | |||
| } | |||
|
|
|||
| // WORKAROUND: To read headers and know if the tile is dropping features. | |||
There was a problem hiding this comment.
What's the condition to finally remove this work-around in the future? Can we better describe it @Josmorsot ?
Ping @felixpalmer if required, to have the next step 100% clear
There was a problem hiding this comment.
we have no condition to remove this. For now it's the only way to do it.
Authorization header to fetch requests Co-authored-by: Víctor Velarde <victor.velarde@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: (link)
TileLayer cause
unauthorizederror due to breaking changes indeck.gl.Type of change