Add Clear button to RangeWidget #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const resetSlider = () => { | ||
| const newValues = [min, max]; | ||
| setInputsValues(newValues); | ||
| setSliderValues([...newValues]); |
There was a problem hiding this comment.
Do we need here destructuring?
There was a problem hiding this comment.
Probably not but it's used in other pieces of the component. I assumed that @padawannn found some problem and needed to use destructuring here:
6165e35 to
8d55289
Compare
bbecquet
suggested changes
Oct 14, 2022
bbecquet
reviewed
Oct 14, 2022
bbecquet
approved these changes
Oct 14, 2022
Pull Request Test Coverage Report for Build 3249564739
💛 - Coveralls |
CHANGELOG.md
Outdated
| @@ -4,6 +4,8 @@ | |||
|
|
|||
| - Update Storybook to v6.5.12 [#487](https://github.com/CartoDB/carto-react/pull/487) | |||
|
|
|||
There was a problem hiding this comment.
Remove extra line here, please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add clear button to reset RangeWidget filters.
Screen.Recording.2022-10-07.at.10.52.03.mov
Type of change