LegendCategories: add maskedMarkers that allows disabling mask icons #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #261239: Render custom markers original color. |
Pull Request Test Coverage Report for Build 3182209925
💛 - Coveralls |
VictorVelarde
approved these changes
Oct 4, 2022
There was a problem hiding this comment.
LGTM @zbigg, but I miss a note in the changelog. Please add it, before moving on
1dbbeb9 to
39cb3c3
Compare
bbecquet
approved these changes
Oct 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/261239/render-custom-markers-original-color
LegendCategories is used to display legend entries in builder and we should support displaying them also with original colors.
Dependency of: https://github.com/CartoDB/cloud-native/pull/9395
Example shot from builder:
Type of change
Acceptance
Builder tests should pass in https://github.com/CartoDB/cloud-native/pull/9395
Unit-tests provided in PR.
Basic checklist