Switch to using quadbin library #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 3135213924
💛 - Coveralls |
padawannn
approved these changes
Sep 13, 2022
|
To be released after new alpha with visgl/deck.gl#7257. CI will fail in the meantime, till we have a new alpha from deck.gl |
02f2978 to
cee90a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/255812/add-functions-to-quadbin-js-as-required-by-carto4react
To better allow developers we have extracted the quadbin logic to a new library: https://github.com/CartoDB/quadbin-js
See related PR in deck: visgl/deck.gl#7257
Type of change
Acceptance
Please describe how to validate the feature or fix