Use unique feature id from tileset if provided #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #253930: Unique id property from fields. |
Pull Request Test Coverage Report for Build 2977824999
💛 - Coveralls |
0c45464 to
db60905
Compare
| }); | ||
|
|
||
| // prettier-ignore | ||
| expect(properties).toEqual([ |
There was a problem hiding this comment.
Nice test here @bbecquet 👍🏻
VictorVelarde
approved these changes
Sep 1, 2022
There was a problem hiding this comment.
I think changes make sense. Confirm with @padawannn and please go ahead with the release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Shortcut: https://app.shortcut.com/cartoteam/story/253930/unique-id-property-from-fields
Modify the feature filter for tiles to take into account the newly provided explicit unique ID, so features are properly identified and not counted multiple times if they intersect multiple tiles.
Type of change