Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix updateLayer reducer to allow remove the legend #448

Merged
merged 4 commits into from
Jul 6, 2022

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Jul 6, 2022

Using the current code if you want to remove the legend, you cannot do it because once the layer is added, this code ...(layer.legend && { is always true.

@Clebal Clebal requested a review from eamador July 6, 2022 13:25
@coveralls
Copy link
Collaborator

coveralls commented Jul 6, 2022

Pull Request Test Coverage Report for Build 2623199681

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 72.015%

Totals Coverage Status
Change from base Build 2622416248: -0.01%
Covered Lines: 1606
Relevant Lines: 2087

💛 - Coveralls

@Clebal Clebal merged commit b151264 into master Jul 6, 2022
@Clebal Clebal deleted the sclebal/fix-update-layer branch July 6, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants