Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow FormulaWidget column to be undefined when using COUNT #434

Merged
merged 2 commits into from
Jun 17, 2022
Merged

Allow FormulaWidget column to be undefined when using COUNT #434

merged 2 commits into from
Jun 17, 2022

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Jun 17, 2022 •
edited
Loading

  • Added checkFormulaColumn in PropTypes for a smarter check about when the column property must be defined or not.
  • Modified features.worker.js to avoid column assert if column is undefined.

@Clebal Clebal requested a review from bbecquet June 17, 2022 07:07
@coveralls
Copy link
Collaborator

coveralls commented Jun 17, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2513944058

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.404%
Totals Coverage Status
Change from base Build 2493882279: 0.0%
Covered Lines: 1600
Relevant Lines: 2072
💛 - Coveralls

@Clebal Clebal merged commit 230e7c7 into master Jun 17, 2022
@Clebal Clebal deleted the bug/fix-formula-widget-count-column branch June 17, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbecquet bbecquet bbecquet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Clebal @coveralls @bbecquet