Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use en dash for intervals instead of hyphen #429

Merged
merged 6 commits into from
Jun 10, 2022
Merged

Use en dash for intervals instead of hyphen #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e088fd9
Use en dash for intervals instead of hyphen [sc-235054]
Clebal Jun 10, 2022
f0f581d
Update CHANGELOG.md
Jun 10, 2022
e0d5bdb
Fix style
Clebal Jun 10, 2022
da1f221
Merge branch 'bug/sc-235054/use-en-dash-for-intervals-instead-of-hyph…
Clebal Jun 10, 2022
cb3a6ff
Merge branch 'master' of github.com:CartoDB/carto-react into bug/sc-2…
Clebal Jun 10, 2022
98ff57d
Update CHANGELOG.md
Jun 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

- Spatial index support for useCartoLayerProps [#425](https://github.com/CartoDB/carto-react/pull/425)
- Ensure source exists in HistogramWidget before getting stats [#426](https://github.com/CartoDB/carto-react/pull/426)
- Use en dash for intervals instead of hyphen [#428](https://github.com/CartoDB/carto-react/pull/428)
- Use en dash for intervals instead of hyphen [#428](https://github.com/CartoDB/carto-react/pull/428) and [#429](https://github.com/CartoDB/carto-react/pull/429)

## 1.3

Expand Down
2 changes: 1 addition & 1 deletion packages/react-ui/src/widgets/HistogramWidgetUI/HistogramWidgetUI.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ function defaultTooltipFormatter(params, xAxisFormatter, yAxisFormatter) {
}

const [left, right, value] = params.data.value;
const title = `${processFormatterRes(xAxisFormatter(left))} — ${processFormatterRes(
const title = `${processFormatterRes(xAxisFormatter(left))} <span style="vertical-align: 1px;">—</span> ${processFormatterRes(
xAxisFormatter(right)
)}`;
const formattedValue = processFormatterRes(yAxisFormatter(value));
Expand Down