Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warning to widgets when column is missing #427

Merged
merged 12 commits into from
Jun 13, 2022
Merged

Add warning to widgets when column is missing #427

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
70f9d28
Add warning to widgets when used column is [sc-234842]
Clebal Jun 9, 2022
d131060
Update useWidgetFetch tests
Clebal Jun 9, 2022
f5b6c9b
Handle model api missing columns error
Clebal Jun 13, 2022
57db12d
Minor fix
Clebal Jun 13, 2022
65d5ba4
Merge branch 'master' into feature/sc-234842/add-warning-to-widgets-w…
Jun 13, 2022
ae8b092
Merge branch 'master' into feature/sc-234842/add-warning-to-widgets-w…
Jun 13, 2022
e2e44c5
Use common error when InvalidColumnError is thrown
Clebal Jun 13, 2022
d9868f5
Update CHANGELOG.md
Jun 13, 2022
d9f50bc
Make code more robust
Clebal Jun 13, 2022
e6b6ae8
Merge branch 'feature/sc-234842/add-warning-to-widgets-when-used-colu…
Clebal Jun 13, 2022
1562ce2
Fix tests
Clebal Jun 13, 2022
86471ec
Modify invalid column err message
Clebal Jun 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle model api missing columns error
  • Loading branch information
@Clebal
Clebal committed Jun 13, 2022
commit f5b6c9b364b0b5894d081fe6b7de5af652afea36
4 changes: 4 additions & 0 deletions packages/react-api/src/api/common.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ export function dealWithApiError({ response, data }) {
throw new InvalidColumnError(`${data.error} ${data.column_name}`);
}

if (data.error.includes('Missing columns')) {
throw new InvalidColumnError(data.error);
}

switch (response.status) {
case 401:
throw new Error('Unauthorized access. Invalid credentials');
Expand Down