-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Stats API fn #404
Conversation
Pull Request Test Coverage Report for Build 2352682224
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nitpick, otherwise LGTM.
…implement-stats-api-fn
…implement-stats-api-fn
data = await response.json(); | ||
} catch (error) { | ||
if (error.name === 'AbortError') throw error; | ||
let data = await makeCall({ url, credentials, opts }); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor
min: 0, | ||
max: 7, | ||
quantiles: { | ||
3: [0, 7], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice piramid 🔺 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very beautiful hahaha.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 . You're free to go @Clebal
I implemented a fn to call the Stats API. In order to make the Stats API available also for static tilesets I implemented getTileJson which makes a Maps API request.