Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Stats API fn #404

Merged
merged 12 commits into from
May 20, 2022
Merged

Implement Stats API fn #404

merged 12 commits into from
May 20, 2022

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented May 5, 2022

I implemented a fn to call the Stats API. In order to make the Stats API available also for static tilesets I implemented getTileJson which makes a Maps API request.

@coveralls
Copy link
Collaborator

coveralls commented May 5, 2022

Pull Request Test Coverage Report for Build 2352682224

  • 37 of 42 (88.1%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 73.678%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-api/src/api/common.js 7 12 58.33%
Totals Coverage Status
Change from base Build 2346530600: 0.3%
Covered Lines: 1623
Relevant Lines: 2064

💛 - Coveralls

Copy link
Contributor

@zbigg zbigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor nitpick, otherwise LGTM.

packages/react-api/src/api/stats.js Outdated Show resolved Hide resolved
data = await response.json();
} catch (error) {
if (error.name === 'AbortError') throw error;
let data = await makeCall({ url, credentials, opts });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor

@VictorVelarde VictorVelarde requested a review from padawannn May 19, 2022 07:26
@Clebal Clebal marked this pull request as ready for review May 19, 2022 10:14
min: 0,
max: 7,
quantiles: {
3: [0, 7],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice piramid 🔺 !

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's very beautiful hahaha.

@VictorVelarde VictorVelarde self-assigned this May 19, 2022
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 . You're free to go @Clebal

@Clebal Clebal merged commit fee64d8 into master May 20, 2022
@Clebal Clebal deleted the feature/implement-stats-api-fn branch May 20, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants