Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecated warning in HistogramWidgetUI #401

Merged
merged 2 commits into from
May 5, 2022
Merged

Fix deprecated warning in HistogramWidgetUI #401

merged 2 commits into from
May 5, 2022

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented May 5, 2022

api.style() is deprecated in echarts, so a warning was shown in each render. I've changed the code so we don't use any deprecated fn.

@Clebal Clebal requested a review from eamador May 5, 2022 09:16
eamador
eamador approved these changes May 5, 2022
View reviewed changes
Copy link
Contributor

@eamador eamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link
Collaborator

coveralls commented May 5, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2274772231

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 74.787%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/HistogramWidgetUI/HistogramWidgetUI.js 0 2 0.0%
Totals Coverage Status
Change from base Build 2270436922: -0.2%
Covered Lines: 1539
Relevant Lines: 1936
💛 - Coveralls

@Clebal Clebal merged commit 012fa06 into master May 5, 2022
@Clebal Clebal deleted the chore/fix-deprecated-warning-in-histogram-widget-ui branch May 5, 2022 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamador eamador eamador approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Clebal @coveralls @eamador