Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeSeries - Restrict animation when using global mode #399

Merged

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented May 4, 2022

Story details: https://app.shortcut.com/cartoteam/story/227983

image

A warning is shown in console if the user wants to show animation controls and use global at the same time. Also the showControls prop is forced to false when global is enabled.

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #227983: TimeSeries - Restrict animation when using global mode.

@Clebal Clebal requested a review from eamador May 4, 2022 14:12
@coveralls
Copy link
Collaborator

coveralls commented May 4, 2022

Pull Request Test Coverage Report for Build 2270303349

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 74.968%

Totals Coverage Status
Change from base Build 2268896121: 0.0%
Covered Lines: 1543
Relevant Lines: 1939

💛 - Coveralls

Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Clebal Clebal merged commit 2484fc1 into master May 4, 2022
@Clebal Clebal deleted the feature/sc-227983/timeseries-restrict-animation-when-using branch May 4, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants