Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement CLOSED_OPEN and TIME filters for SQL to allow proper filtering #381

Merged
merged 3 commits into from
Apr 22, 2022
Merged

Implement CLOSED_OPEN and TIME filters for SQL to allow proper filtering #381

merged 3 commits into from
Apr 22, 2022

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Apr 22, 2022

No description provided.

@Clebal Clebal requested a review from VictorVelarde April 22, 2022 08:30
@coveralls
Copy link
Collaborator

coveralls commented Apr 22, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2206763950

  • 47 of 47 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 75.033%
Totals Coverage Status
Change from base Build 2197008878: 0.2%
Covered Lines: 1480
Relevant Lines: 1861
💛 - Coveralls

eamador
eamador approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@eamador eamador left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the Victor's comment, but looks great! 🚀

@eamador eamador self-requested a review April 22, 2022 08:39
@VictorVelarde VictorVelarde changed the title Implement CLOSED_OPEN and TIME filters for SQL Implement CLOSED_OPEN and TIME filters for SQL to allow proper filtering Apr 22, 2022
@Clebal
Copy link
Contributor Author

Clebal commented Apr 22, 2022

Fixed @eamador @VictorVelarde

VictorVelarde
VictorVelarde approved these changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@VictorVelarde VictorVelarde merged commit 0c6c95a into master Apr 22, 2022
@VictorVelarde VictorVelarde deleted the sclebal/implement-sql-filters branch April 22, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVelarde VictorVelarde VictorVelarde approved these changes

@eamador eamador Awaiting requested review from eamador

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Clebal @coveralls @VictorVelarde @eamador