Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WrapperWidgetUI support externally controlled expanded attribute #375

Merged
merged 6 commits into from
Apr 11, 2022
Merged

WrapperWidgetUI support externally controlled expanded attribute #375

merged 6 commits into from
Apr 11, 2022

Conversation

zbigg
Copy link
Contributor

@zbigg zbigg commented Apr 11, 2022 •
edited
Loading

Description

Shortcut: https://app.shortcut.com/cartoteam/story/212117/collapsed-state-of-widgets-is-not-saved

WrapperWidgetUI support externally controlled expanded attribute, so builder can control it and save in Widget state.

If this PR requires a companion in carto-react-template, please also link them both.

Type of change

  • Feature

Acceptance

Unit-tests added
Demo in https://github.com/CartoDB/cloud-native/pull/5736

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #212117: Collapsed state of widgets is not saved.

@zbigg zbigg force-pushed the feature/sc-212117/collapsed-state-of-widgets-is-not-saved branch from 62106d1 to 2e43a9b Compare April 11, 2022 13:01
@zbigg zbigg marked this pull request as ready for review April 11, 2022 13:04
@zbigg zbigg force-pushed the feature/sc-212117/collapsed-state-of-widgets-is-not-saved branch from 2e43a9b to b7a80e7 Compare April 11, 2022 13:05
@coveralls
Copy link
Collaborator

coveralls commented Apr 11, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2149031487

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 73.724%
Totals Coverage Status
Change from base Build 2147980831: 0.07%
Covered Lines: 1320
Relevant Lines: 1692
💛 - Coveralls

eamador
eamador approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@eamador eamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zbigg zbigg force-pushed the feature/sc-212117/collapsed-state-of-widgets-is-not-saved branch from 2bb5773 to d334b5e Compare April 11, 2022 13:48
@zbigg zbigg force-pushed the feature/sc-212117/collapsed-state-of-widgets-is-not-saved branch from d334b5e to b6fc202 Compare April 11, 2022 13:57
VictorVelarde
VictorVelarde approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 Let's wait for @borja-munoz confirmation on new behaviour before we merge

@zbigg zbigg merged commit f508f9a into master Apr 11, 2022
@VictorVelarde VictorVelarde mentioned this pull request Apr 12, 2022
Merged
@zbigg zbigg deleted the feature/sc-212117/collapsed-state-of-widgets-is-not-saved branch October 4, 2022 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamador eamador eamador approved these changes

@VictorVelarde VictorVelarde VictorVelarde approved these changes

@bbecquet bbecquet bbecquet approved these changes

@Clebal Clebal Awaiting requested review from Clebal

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@zbigg @coveralls @bbecquet @VictorVelarde @eamador