Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add RegExp string filtering capabilities #362

Merged
merged 8 commits into from
Mar 23, 2022
Merged

Add RegExp string filtering capabilities #362

merged 8 commits into from
Mar 23, 2022

Conversation

juandjara
Copy link
Contributor

@juandjara juandjara commented Mar 22, 2022 •
edited
Loading

Description

Shortcut: https://app.shortcut.com/cartoteam/story/217708/support-regexp-in-string-search-filter

This PR adds the ability to use regexp values in the STRING_SEARCH filter type as discused in the RFC https://app.shortcut.com/cartoteam/story/216334/rfc-support-regex-in-string-search-filter

Type of change

  • Feature

Acceptance

Please describe how to validate the feature or fix

  1. See attached tests
  2. Add regex value to string search filter
  3. check that filter is working

Basic checklist

  • Good PR name
  • Shortcut link
  • Changelog entry
  • Just one issue per PR
  • GitHub labels
  • Proper status & reviewers
  • Tests
  • Documentation

@juandjara juandjara requested a review from Clebal March 22, 2022 10:13
@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #217708: Support regexp in STRING_SEARCH filter.

@juandjara juandjara changed the title Feature/ch217708/regexp string filtering RegExp String Filtering Mar 22, 2022
@Clebal Clebal requested a review from bbecquet March 22, 2022 10:17
@coveralls
Copy link
Collaborator

coveralls commented Mar 22, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2023153109

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 73.14%
Totals Coverage Status
Change from base Build 1993272450: 0.01%
Covered Lines: 1292
Relevant Lines: 1665
💛 - Coveralls

@juandjara juandjara changed the title RegExp String Filtering Add regexp string filtering capabilities Mar 22, 2022
@juandjara juandjara changed the title Add regexp string filtering capabilities Add RegExp string filtering capabilities Mar 22, 2022
Clebal
Clebal approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@Clebal Clebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition 🚀

@Clebal
Copy link
Contributor

Clebal commented Mar 23, 2022

I like the new changes @juandjara! It's great. What do you think @bbecquet?

@Clebal Clebal merged commit bd366b9 into master Mar 23, 2022
@Clebal Clebal deleted the feature/ch217708/regexp-string-filtering branch March 23, 2022 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clebal Clebal Clebal approved these changes

@bbecquet bbecquet bbecquet left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@juandjara @coveralls @Clebal @bbecquet