-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add groupByDate tests #346
Conversation
Pull Request Test Coverage Report for Build 1877236689
💛 - Coveralls |
}); | ||
|
||
test(GroupDateTypes.MONTHS, () => { | ||
ARGS[3] = GroupDateTypes.MONTHS; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be probably easier to read if your ARGS is a dictionary, not array, and you do
const params = { features, operation, date, grouping }
// ...
params.grouping = XXX
// ...
executeGroupByDateFnTests(params, RESULT);
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much better! I changed it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.