Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add groupByDate tests #346

Merged
merged 5 commits into from
Feb 21, 2022
Merged

Add groupByDate tests #346

merged 5 commits into from
Feb 21, 2022

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Feb 21, 2022

No description provided.

@coveralls
Copy link
Collaborator

coveralls commented Feb 21, 2022

Pull Request Test Coverage Report for Build 1877236689

  • 21 of 21 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 72.537%

Totals Coverage Status
Change from base Build 1864689908: 1.9%
Covered Lines: 1282
Relevant Lines: 1664

💛 - Coveralls

});

test(GroupDateTypes.MONTHS, () => {
ARGS[3] = GroupDateTypes.MONTHS;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be probably easier to read if your ARGS is a dictionary, not array, and you do

const params = { features, operation, date, grouping }
// ...
params.grouping = XXX
// ...
executeGroupByDateFnTests(params, RESULT);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better! I changed it :)

Copy link
Contributor

@VictorVelarde VictorVelarde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Clebal Clebal merged commit 72ee22a into master Feb 21, 2022
@Clebal Clebal deleted the feature/add-groupByDate-tests branch February 21, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants