Add searchable prop in CategoryWidget to optionally use the search functionality #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #210130: Add searchable prop in CategoryWidget to optionally use the search functionality. |
added 2 commits
February 16, 2022 14:54
Pull Request Test Coverage Report for Build 1877950155
💛 - Coveralls |
|
Sergio, I think we are missing the number of Others categories within parenthesis, as defined by @josegilg |
added 4 commits
February 17, 2022 11:32
…sc-210130/add-searchable-prop-in-categorywidget-to # Conflicts: # CHANGELOG.md
| const blocked = blockedCategories.length; | ||
| return blocked ? data.length - blocked : data.length - maxItems; | ||
| }, [data, maxItems, blockedCategories]); | ||
|
|
||
| // Separated to simplify the widget layout but inside the main component to avoid passing all dependencies | ||
| const CategoryItem = (props) => { |
There was a problem hiding this comment.
Any refactor here, moving 'internal' components to different files would be really appreciated
There was a problem hiding this comment.
Great, I'll add it to my backlog 👌
zbigg
approved these changes
Feb 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story details: https://app.shortcut.com/cartoteam/story/210130