-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix duplicated logic for category selection in PieWidgetUI #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juandjara
changed the title
fix PieWidgetUI click event
fix duplicated logic in PieWidgetUI click event
Feb 15, 2022
Pull Request Test Coverage Report for Build 1848313894
💛 - Coveralls |
juandjara
changed the title
fix duplicated logic in PieWidgetUI click event
fix duplicated logic for category selection in PieWidgetUI
Feb 15, 2022
Clebal
approved these changes
Feb 15, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
juandjara
added a commit
that referenced
this pull request
Apr 5, 2022
This PR is meant to bring back a bug fix that was performed in PR #332 but overwritten in PR #341 (both from version 1.2.1-beta.8) The bug fix consisted in fixing the category selection logic for the PieWidgetUI component to avoid using `labels` in the selected category comparison and use the categories from `data` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the behaviour of PieWidgetUI
clickEvent
, removing duplicated logic that was re-appliying UI changes already applied in otheruseEffect
calls. Before this changes, you couldn't recieve theonSelectedCategoriesChange
event without affecting the UI of the chart. This change makes it so you can better control if the component is controlled or uncontrolled.Type of change
Acceptance
Acceptance is described here in terms of the component API
const categories = useRef([])
<PieWidgetUI />
selectedCategories={categories.current}
andonSelectedCategoriesChange={(value) => console.log(value)}
Basic checklist