Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export FilterTypes enum #314

Merged
merged 3 commits into from
Feb 8, 2022
Merged

Export FilterTypes enum #314

merged 3 commits into from
Feb 8, 2022

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Feb 8, 2022 •
edited
Loading

In order to be used in TypeScript, FilterTypes has to be exported. Before this change, we had to use @ts-ignore everywhere we used it.

@Clebal Clebal requested a review from VictorVelarde February 8, 2022 07:22
@Clebal Clebal added the enhancement New feature or request label Feb 8, 2022
@coveralls
Copy link
Collaborator

coveralls commented Feb 8, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1811920276

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.236%
Totals Coverage Status
Change from base Build 1811555334: 0.0%
Covered Lines: 1166
Relevant Lines: 1563
💛 - Coveralls

@Clebal Clebal requested a review from eamador February 8, 2022 10:48
eamador
eamador approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@eamador eamador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Clebal Clebal merged commit 90f9190 into master Feb 8, 2022
@Clebal Clebal deleted the feature/export-filter-types-enum branch February 8, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamador eamador eamador approved these changes

@VictorVelarde VictorVelarde Awaiting requested review from VictorVelarde

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Clebal @coveralls @eamador