Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ch122277/list component meta value #31

Merged
merged 5 commits into from
Dec 1, 2020

Conversation

edgarberm
Copy link
Contributor

No description provided.

@edgarberm edgarberm requested a review from neokore November 26, 2020 14:48
@@ -1,6 +1,9 @@
## Unreleased
- Make OAuthLogin component responsive [#28](https://github.com/CartoDB/carto-react-lib/pull/28)

## 1.0.0-beta5 (2020-11-26)
- Added meta value version to List component [#31](https://github.com/CartoDB/carto-react-lib/pull/31)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this item to ##Unreleased section, please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor

@neokore neokore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, move the changelog item and let's merge it

Copy link
Contributor

@neokore neokore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neokore neokore merged commit 69e384d into master Dec 1, 2020
@neokore neokore deleted the feature/ch122277/list-component-meta-value branch December 1, 2020 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants