Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove custom ToggleButtonGroup and ToggleButton default size value #289

Merged
merged 2 commits into from
Jan 20, 2022
Merged

Remove custom ToggleButtonGroup and ToggleButton default size value #289

merged 2 commits into from
Jan 20, 2022

Conversation

Clebal
Copy link
Contributor

@Clebal Clebal commented Jan 20, 2022

In the PR #269, Edgar modified the default size value for ToggleButtonGroup and ToggleButton components.

In Material UI, both components have medium size as default value, instead of small.

That change made the projects styles to break:

Using small:
image

Using medium:
image

This PR is to remove small size, and leave the default Material UI value as our default value.

@Clebal Clebal requested a review from edgarberm January 20, 2022 09:12
edgarberm
edgarberm approved these changes Jan 20, 2022
View reviewed changes
Copy link
Contributor

@edgarberm edgarberm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Clebal Clebal changed the title Remove custom default ToggleButtonGroup and ToggleButton size Remove custom ToggleButtonGroup and ToggleButton default size value Jan 20, 2022
@coveralls
Copy link
Collaborator

coveralls commented Jan 20, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1722552431

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.375%
Totals Coverage Status
Change from base Build 1719774158: 0.0%
Covered Lines: 1155
Relevant Lines: 1544
💛 - Coveralls

@Clebal Clebal merged commit ebaaedd into master Jan 20, 2022
@Clebal Clebal deleted the sclebal/set-default-togglebutton-size branch January 20, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edgarberm edgarberm edgarberm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Clebal @coveralls @edgarberm