Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve styles for MaterialUI - Dialog component #272

Merged
merged 4 commits into from
Jan 21, 2022
Merged

Improve styles for MaterialUI - Dialog component #272

merged 4 commits into from
Jan 21, 2022

Conversation

edgarberm
Copy link
Contributor

@edgarberm edgarberm commented Jan 12, 2022 •
edited by VictorVelarde
Loading

@shortcut-integration
Copy link

This pull request has been linked to Shortcut Story #145205: Develop Dialogs (modals).

@coveralls
Copy link
Collaborator

coveralls commented Jan 12, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1728178857

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.415%
Totals Coverage Status
Change from base Build 1728042985: 0.0%
Covered Lines: 1155
Relevant Lines: 1544
💛 - Coveralls

Josmorsot
Josmorsot requested changes Jan 17, 2022
View reviewed changes
Copy link
Contributor

@Josmorsot Josmorsot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you open this story appears the next thing:
image

@builtbyedgar Could you take a look?

@VictorVelarde VictorVelarde self-requested a review January 18, 2022 18:04
@VictorVelarde
Copy link
Contributor

@builtbyedgar if you can't currently work in the project, ping us so we can see how to manage CR changes

@VictorVelarde VictorVelarde changed the title Feature/ch145205/dialog Improve styles for for MaterialUI Dialog component Jan 18, 2022
@VictorVelarde VictorVelarde changed the title Improve styles for for MaterialUI Dialog component Improve styles for MaterialUI Dialog component Jan 18, 2022
@VictorVelarde VictorVelarde changed the title Improve styles for MaterialUI Dialog component Improve styles for MaterialUI - Dialog component Jan 18, 2022
@Josmorsot
Copy link
Contributor

Acceptance OK

@VictorVelarde
Copy link
Contributor

@Josmorsot. You should take this one, when you can

@Josmorsot Josmorsot force-pushed the feature/ch145205/dialog branch from 10afa18 to 7766f2d Compare January 21, 2022 10:28
Josmorsot
Josmorsot approved these changes Jan 21, 2022 •
edited
Loading
View reviewed changes
@Josmorsot Josmorsot merged commit 59db5a3 into master Jan 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josmorsot Josmorsot Josmorsot approved these changes

@VictorVelarde VictorVelarde Awaiting requested review from VictorVelarde

Assignees
No one assigned
Labels
material-ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@edgarberm @coveralls @VictorVelarde @Josmorsot