-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow disable widgets filtering #268
Allow disable widgets filtering #268
Conversation
This pull request has been linked to Shortcut Story #193004: Disable interactivity for widgets. |
Pull Request Test Coverage Report for Build 1668486363
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM, nice addition @Clebal
Just a question: to land this (for an alpha) we can do it without updating docs & without any example on carto-react-template, but I think it would be nice to create also those other 2 small companion PRs, is that possible?.
If not, we can do that later, when making official 1.2 release... thoughts ? cc/ @borja-munoz
@VictorVelarde totally agree. But I cannot tackle that right now since I don't have specific dedication for C4R, I'm sorry. I can make it in a future, maybe for the final release. |
In my opinion, the carto-react-template example is not mandatory in this case, but updating the documentation (adding the property to the reference) is a must. |
I've created this task for doc (https://app.shortcut.com/cartoteam/story/202069/widgets-document-new-filterable-prop-for-widgets), but I think we can already land this one |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Story details: https://app.shortcut.com/cartoteam/story/193004
Added property
filterable
in every widget with filtering capabilities.When
filterable
is false, widget's click event is disabled.