Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use zero-based pagination for getRawFeatures #265

Merged
merged 1 commit into from
Jan 3, 2022
Merged

Use zero-based pagination for getRawFeatures #265

merged 1 commit into from
Jan 3, 2022

Conversation

bbecquet
Copy link
Contributor

@bbecquet bbecquet commented Jan 3, 2022

Small adjustment on the TableWidget and getRawFeatures, following discussion with @Clebal #154 (comment)

Instead of using a 1-based pagination, let's switch to 0-based. This makes it consistent with MUI pagination.

@bbecquet bbecquet requested review from Clebal and padawannn January 3, 2022 11:37
@coveralls
Copy link
Collaborator

coveralls commented Jan 3, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1649411094

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.303%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/react-ui/src/widgets/TableWidgetUI/TableWidgetUI.js 0 2 0.0%
Totals Coverage Status
Change from base Build 1649129920: 0.0%
Covered Lines: 1142
Relevant Lines: 1529
💛 - Coveralls

Clebal
Clebal approved these changes Jan 3, 2022
View reviewed changes
Copy link
Contributor

@Clebal Clebal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

packages/react-widgets/src/widgets/TableWidget.js Outdated Show resolved Hide resolved
@bbecquet bbecquet force-pushed the zero-based-pagination branch from 9e853e9 to dd526e7 Compare January 3, 2022 13:11
@bbecquet bbecquet merged commit 6be9231 into master Jan 3, 2022
@bbecquet bbecquet deleted the zero-based-pagination branch January 3, 2022 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clebal Clebal Clebal approved these changes

@padawannn padawannn Awaiting requested review from padawannn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bbecquet @coveralls @Clebal